Add SYS_RESOURCE security context capability if not set #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 74.3% 74.38% +0.07%
==========================================
Files 28 28
Lines 1950 1956 +6
==========================================
+ Hits 1449 1455 +6
Misses 383 383
Partials 118 118Continue to review full report at Codecov.
|
schallert
reviewed
May 28, 2019
pkg/k8sops/statefulset.go
Outdated
| } | ||
| } | ||
| if !hasCapabilitySysResource { | ||
| specSecurityCtx.Capabilities.Add = |
There was a problem hiding this comment.
We'll have to only add this if the user hasn't set a securitycontext at all. If they've set one we can't modify it, as they may have PodSecurityPolicies that prevent capabilities from being added, in which case they'd have no way to use the operator. Or we can add another flag to not add it.
I personally like only setting it if there's not an SC already
schallert
force-pushed
the
r/add-sys-resource-capability
branch
from
a309423
to
99f1d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add SYS_RESOURCE to the security context if not set to ensure the M3DB image is able to call the
setrlimitsyscall forRLIMIT_NOFILEwhen it needs to raise the hard and soft open FDs limit to the value offs.nr_openwhen they are not the same.Fixes #137.